Stefan Tauner posted comments on this change.

View Change

Patch set 1:

(1 comment)

Don't see that the hidden behavioural change deserves a fixup. Let
me know if you have strong feelings about that.

<the usual initial git commit argument blabla>
The commit message tries to give some motivations on why these are good ideas. Less interdependence between (the code in) the makefile, the actual vcs used, and getrevision.sh; and it's less but more readable code too :)

To view, visit change 21827. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedc9df4c033a70447b8b1b65c83764c769b02c3f
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 04 Oct 2017 00:25:14 +0000
Gerrit-HasComments: No