Attention is currently required from: Felix Singer, Thomas Heijligen.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 8:

    Please add a link to the datasheet.

    The datasheet is here: https://www.winbond.com/resource-files/W25Q128JV%20RevH%2003102021%20Plus.pdf

    In general we avoid putting URLs in commit messages since they are prone to change. In flashrom we put URLs in print.c which (sort of) works since we can go back and change it easily. Perhaps we should add URLs to the flashchip definitions?

    More background on URLs in commit messages:
    https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/3IRVU3OQ2ZROAIEUHXHPOV235F2L2PK2/

    https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/4F47SFNNRT72C5EA2RTYZWMC26DZM3RO/

• Patchset:

  • Patch Set #1:

    The model ID (0x7018) was already added in CB:28910

To view, visit change 22567. To unsubscribe, or for help writing mail filters, visit settings.