Attention is currently required from: Anastasia Klimchuk, Matti Finder.

View Change

2 comments:

• File meson.build:

  • Patch Set #1, Line 177: enabled

    `enabled` is only true if the feature is set to `enabled` (not `auto`). You probably want `get_option('rpmc').allowed()` since that's true if it's either `auto` or `enabled`.

• File rpmc.c:

  • Patch Set #1, Line 287: unsigned char msg[RPMC_UPDATE_HMAC_KEY_MSG_LENGTH];

    I'd prefer to use initializers for arrays like this (throughout this file), to make it less prone to length-related errors.

    ```
    unsigned char msg[RPMC_UPDATE_HMAC_KEY_MSG_LENGTH] = {
      flash->chip->rpmc_ctx.op1_opcode,
      0x01,
      counter_address,
      ...
    };
    ```

To view, visit change 84934. To unsubscribe, or for help writing mail filters, visit settings.