Attention is currently required from: Anastasia Klimchuk.

7 comments:

File tests/init_shutdown.c:
- Patch Set #1, Line 302:
```
#include <fcntl.h>
#include <linux/i2c-dev.h>
```
  Tests should be as lightweight and independent as possible, they only thing to check is CONFIG_REALT […]
  Done
- Patch Set #1, Line 364: io_mock_register(&realtek_mst_io);
  You need to unregister at the end, […]
  Done
File tests/tests.c:
- Patch Set #1, Line 93:
```
          if (current_io->open64)
            return current_io->open64(current_io->state, pathname, flags);
          if (current_io->open)
            return current_io->open(current_io->state, pathname, flags);
```
  Why do you put both open and open64 into one wrap? There is a dedicated wrap for open, so […]
  The intent is to have open64 delegate to open because I expect users mostly won't care about the difference, but neglected to implement the latter. Moved the open() part to __wrap_open and made __wrap_open64 delegate to it.
- Patch Set #1, Line 120: return -1;
  Default behaviour for our wraps is "do nothing, pretend everything is successful". […]
  Done
- Patch Set #1, Line 127: return current_io->read(current_io->state, fd, buf, sz);
  We are following Linux kernel coding style https://git.kernel. […]
  Neglected to reformat this file but did the other one. Fixed.
- Patch Set #1, Line 128: return -1;
  Same here, you need to return value which means success.
  Done
- Patch Set #1, Line 345: cmocka_unit_test
  Same thing, indentations should be 8 chars
  Done

To view, visit change 56911. To unsubscribe, or for help writing mail filters, visit settings.