Patch set 2:Code-Review +2
View Change
1 comment:
Commit Message:
Patch Set #1, Line 10:
because the vendor_id and device_id fields of struct
pci_dev are not filled in
Sure, I added some more details to the commit message - does this look OK?
LGTM
To view, visit change 46310. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia011d4d801f8a54160e45a70b14b740e6dcc00ef
Gerrit-Change-Number: 46310
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Verkamp <dverkamp@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 13 Oct 2020 20:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Daniel Verkamp <dverkamp@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment