Attention is currently required from: Nico Huber, Angel Pons.
11 comments:
File hwaccess_x86_io.c:
Patch Set #3, Line 23: static int platform_get_io_perms(void)
No need to mention the whole function signature (you too actually didn't […]
Done
Patch Set #3, Line 23: those
No platforms were named to refer to, AFAICT. So I would rather say […]
Done
please separate multiple platforms with a comma
Done
Patch Set #3, Line 49: return sysi86(SI86V86, V86SC_IOPL, PS_IOPL);
This needs <sys/sysi86.h> (our header file already includes it […]
Done
Other functions, e.g. iopl(), ioperm(), return -1 on error.
Done
Patch Set #3, Line 65: return (io_fd = open("/dev/io", O_RDWR) >= 0 ? 0 : 1);
Please do the assignment on a separate line :)
Done
Patch Set #3, Line 92: return iopl(3);
<sys/io. […]
*BSD and Darwin use other includes. The includes are currently in the header and come here with the next commit.
Patch Set #3, Line 114: if (ret == 0)
Please add braces on all paths if one path needs them. Or `return 0` […]
Done
In theory, this could be a return parameter of platform_get_io_perms(). […]
This can be done in a following ccommit.
Patch Set #3, Line 121: msg_perr("On NetBSD please reboot into single user mode or make sure\n"
Can we make the output changes a separate patch?
Done. See Relation Chain
Patch Set #3, Line 124: return ret;
Better use an explicit `return 0`/`return 1` as before. Currently this […]
Done
To view, visit change 61275. To unsubscribe, or for help writing mail filters, visit settings.