Attention is currently required from: Nico Huber, Edward O'Callaghan, Daniel Campello, Anastasia Klimchuk.

View Change

3 comments:

• File layout.c:

  • Patch Set #8, Line 388: *layout = malloc(sizeof(**layout));

    Given that you memset() the allocated space afterwards, use calloc() instead?

  • Patch Set #8, Line 418: entry->next = layout->head;

    I missed the fact that in the beginning when layout has no entries, layout->head is null (or maybe undefined).

    It's null, flashrom_layout_new() zero-initialises the newly-allocated `struct layout`. The null pointer signals the end of the linked list.

  • Patch Set #8, Line 458:

    if (layout == global_layout)
    		return;
    
    	while (layout && layout->head) {
    		struct romentry *const entry = layout->head;
    		layout->head = entry->next;
    		free(entry->file);
    		free(entry->name);
    		free(entry);
    	}
    	free(layout);
    

    Given that `layout` is not modified in the while loop, how about evaluating it once?

      if (!layout || layout == global_layout)
     	return;
     
     while (layout->head) {
     	struct romentry *const entry = layout->head;
     	layout->head = entry->next;
     	free(entry->file);
     	free(entry->name);
     	free(entry);
     }
     free(layout);

To view, visit change 33521. To unsubscribe, or for help writing mail filters, visit settings.