Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.

View Change

2 comments:

• File Makefile:

  • Patch Set #4, Line 783:

    ifneq ($(NEED_RAW_ACCESS), )
    # Raw memory, MSR or PCI port I/O access.
    FEATURE_CFLAGS += -D'NEED_RAW_ACCESS=1' -D'__FLASHROM_HAVE_OUTB__=1'
    PROGRAMMER_OBJS += physmap.o hwaccess.o hwaccess_x86_io.o
    

    Mostly curiosity: what is the way to build with NEED_RAW_ACCESS empty? Would that be disabling all t […]

    Yes, currently it's disabling all libpci programmer and rayer_spi. Building with `make NEED_RAW_ACCESS=` fails during linking.
    On x86 Linux NEED_RAW_ACCESS is enabled by CONFIG_RAYER_SPI which builds by default and all libcpi programmer when libpci is found

• File tests/hwaccess_x86_io_unittest.h:

  • Patch Set #4, Line 33: int rget_io_perms(void);

    If you could move it below all defines and includes (right above iopl)? thanks!

    Done

To view, visit change 60110. To unsubscribe, or for help writing mail filters, visit settings.