Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
View Change
1 comment:
File meson.build:
Patch Set #6, Line 509: # .allowed() is introduced in 0.59.0
It should be mention in the code why we are not using the new .allowed() method. […]
Oh, sorry. Somehow I thought the comment is related to that .enabled. My fault.
However, in this case the comment still looks random and unrelated without your explanation. If this is some kind of "todo" and you want to switch to .allowed(), then we should document this on the issue tracker and not in the code.
To view, visit change 63832. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b
Gerrit-Change-Number: 63832
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Fri, 06 May 2022 03:27:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Gerrit-MessageType: comment