Patch Set 4: Code-Review-1

I understand why it is unwanted for your case, but I don't
understand why the code is suddenly not needed anymore.

My bad here, I didn't realize that deleting parameters is necessary to allow unused parameters to be detected. I'll look into adapting our current code paths that call extract_param() multiple times.

View Change

To view, visit change 44562. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9b1ec2d273c723fef8908e4ddf13b3079924f0a7
Gerrit-Change-Number: 44562
Gerrit-PatchSet: 4
Gerrit-Owner: Nikolai Artemiev <>
Gerrit-Reviewer: Angel Pons <>
Gerrit-Reviewer: Edward O'Callaghan <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-Comment-Date: Tue, 25 Aug 2020 02:17:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment