View Change

8 comments:

• Commit Message:

  • Patch Set #3, Line 7: lspcon_i2c_spi.c: Add support for the i2c-controlled SPI master in PS175/176.

    Please remove the dot/period at the end of the commit message summary.

    You can move this down into the body and have a shorter summary line:

    ```
    lspcon_i2c_spi.c: Add SPI-master support for PS17{5,6}

    This adds support for the Parades lspcon usb-c to dp protocol translator part that is i2c-controlled. The support allows the host to reach the SPI rom that hangs off the part where it stores its firmware.
    ```

• File lspcon_i2c_spi.c:

  • Patch Set #3, Line 33: #define FUNCTION_ERR -1

    use flashrom enum of native error codes.

  • Patch Set #3, Line 80:

    uint8_t data_size;
    	const uint8_t *data;
    

    swap these two for readability?

  • Patch Set #3, Line 105: if (!flash || !flash->mst || !flash->mst->spi.data) {

    under what conditions is this true in practice?

  • Patch Set #3, Line 110: (const struct lspcon_i2c_spi_data *)flash->mst->spi.data

    case to an intermediate and then extract.

  • Patch Set #3, Line 418: int fd = ((struct lspcon_i2c_spi_data *)data)->fd;

    cast it then extract the value.

  • Patch Set #3, Line 487:

    	struct lspcon_i2c_spi_data data = { fd };
    	void *data_ptr = calloc(1, sizeof(data));
    

    just calloc the heap and set the member, avoid the memcpy().

    ```
    struct lspcon_i2c_spi_data * data = calloc(1, sizeof(struct lspcon_i2c_spi_data));
    data->fd = fd;
    ```

  • Patch Set #3, Line 500:

    trim \n

To view, visit change 39687. To unsubscribe, or for help writing mail filters, visit settings.