Attention is currently required from: Nico Huber, Thomas Heijligen, Keno Fischer.
Patch set 2:-Code-Review
View Change
1 comment:
Patchset:
Patch Set #2:
I think it would be better to integrate the message into `platform_get_io_perms` instead of using ad […]
Thanks for the insight, Thomas.
Keno, you can swap the order of your two patches so that adding the message doesn't depend on this change. Sorry for the trouble.
To view, visit change 68468. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4d1e369cb60e160f555f1f9f0c832fe27b75e9de
Gerrit-Change-Number: 68468
Gerrit-PatchSet: 2
Gerrit-Owner: Keno Fischer <keno@alumni.harvard.edu>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Keno Fischer <keno@alumni.harvard.edu>
Gerrit-Comment-Date: Mon, 17 Oct 2022 17:54:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Gerrit-MessageType: comment