I'll take it as is. You can still optimize that delay in a follow-up
if you want.
Patch set 6:Code-Review +2
View Change
1 comment:
File buspirate_spi.c:
Patch Set #6, Line 473: sleep(1);
It's really just a safe value. […]
Idk, if it's worth it depends pretty much on the optimal value. e.g.
if it's <1ms, it's definitely worth it, if >500ms, rather not.
OTOH, if it's close to 1s, we might not be even safe yet. So it would
be be nice to know, even if we don't optimize it ;)
To view, visit change 23057. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3706f17a94fdf056063f2ad4a5f0a219665cdcbf
Gerrit-Change-Number: 23057
Gerrit-PatchSet: 6
Gerrit-Owner: Shawn Anastasio <shawnanastasio@yahoo.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Shawn Anastasio <shawnanastasio@yahoo.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 26 Jan 2018 15:22:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes