It's moving into the right direction. But I'd still like to have that
discussion about CrOS interface compatibility. If we decide to uncon-
ditionally keep that (over possibly better interface choices), that's
a very influental decision for the project. And shouldn't be made in
a review.

Just imagine how fast this change could have been done for flashrom
proper if we'd just kept the idea (per region files) and implemented
it consistently with good old flashrom quality. I'd estimate a third
of the time we already spent so far for gathering old commits, poli-
shing, discussing.

Patch set 7:Code-Review -1

View Change

1 comment:

• File cli_classic.c:

  • Patch Set #7, Line 347: char ** argv_copy = malloc((argc + 1) * sizeof(*argv_copy));

    I'm not fully awake yet. Though, can't you just use

        argv + optind

    instead of a copy?

    Either way you don't seem to reset `optind`, so the copied `argv[j]`
    with `j < optind` won't be considered by getopt_long() anyway. Which
    is just fine. But makes this code a hell to follow...

To view, visit change 23022. To unsubscribe, or for help writing mail filters, visit settings.