Attention is currently required from: Edward O'Callaghan, Jes Klinke.

6 comments:

Commit Message:
- Patch Set #2, Line 42: target=1
  Since these are new values for `target` param, please document it on the manpage, here:
```
 doc/classic_cli_manpage.rst
```
- Patch Set #2, Line 45: archieves
  achieves (typo)
- Patch Set #2, Line 48: run flashrom with HyperDebug
  Could you please list the exact commands that you ran?
  I read the commit message (thank you for providing so many details), and it would be ideal to run flashrom with both new and old values of `target` param. Run and then add to commit message, thank you!
Patchset:
- Patch Set #2:
  Jes, thank you for the patch! I have few comments.
File raiden_debug_spi.c:
- Patch Set #2, Line 1596: request_enable & 0xFF
  Does this still work for target values EC and AP ?
- Patch Set #2, Line 1596:
```
request_enable & 0xFF,
				(request_enable >> 8) & 0xFF,
```
  A question: why do you initialise `request_enable` to a value that you never use by itself, just as `request_enable`? I see it is used as `request_enable & 0xFF` and as `(request_enable >> 8) & 0xFF` but never by itself?
  What is the meaning of `request_enable` ?

To view, visit change 77999. To unsubscribe, or for help writing mail filters, visit settings.