Attention is currently required from: Light.
View Change
2 comments:
Commit Message:
Patch Set #1, Line 11:
You can add information on how you tested this patch. For example, you found this by running scan-build, so you can say that you ran scan-build before and after and the issue disappeared (if this is true of course).
Patchset:
Patch Set #1:
Welcome Aarya! You will need to read all the comments carefully, fix all them and upload new version of this patch (new patchset). If you don't understand the comment, it is totally fine to ask for clarification, and what does the comment mean. Good luck! :)
To view, visit change 62724. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301
Gerrit-Change-Number: 62724
Gerrit-PatchSet: 1
Gerrit-Owner: Light <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Light <aarya.chaumal@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 09:46:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment