Patch Set 3: Code-Review+2

Patch Set 3: Code-Review+2

All-in-all this seems like a great step forward for build testing. I looked over the patch chain and it seems OK (nice Make-fu), but unfortunately it failed to run and I couldn't figure out why in the short amount of time I had.

Some day I'd like to re-write most of the Makefile logic in Go or shell and hopefully make it easier to understand and modify, but that shouldn't block this patch.

I was able to run this on poweredgy (my Dell Poweredge R900 space heater) some time ago.

I should clarify - I was able to run it, but there were a couple errors such as:
make[1]: *** [Makefile:39: fedora:30-aarch64-build] Error 1

I'm just not sure how to determine what's going on and how to fix it. It doesn't seem to be the fault of manibuilder per se, so I think we should get this in, use it, and improve it and add more documentation as we go.

View Change

To view, visit change 23005. To unsubscribe, or for help writing mail filters, visit settings.