
Mary Ruthven has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43527 ) Change subject: raiden_debug_spi: add param for a custom reset setup ...................................................................... Patch Set 5: (3 comments) https://review.coreboot.org/c/flashrom/+/43527/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/43527/3//COMMIT_MSG@9 PS3, Line 9: Cr50
It's technically not a TPM, and haven't seen it being called a "chromium tpm" before. […] Done
https://review.coreboot.org/c/flashrom/+/43527/3//COMMIT_MSG@10 PS3, Line 10: some boards.
`some Chromium boards` also would be nice to elaborate here a little more, breaks how? […] Done
https://review.coreboot.org/c/flashrom/+/43527/3/raiden_debug_spi.c File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/43527/3/raiden_debug_spi.c@458 PS3, Line 458: tract_programmer_param("custom_rst");
Any new parameters should be documented in the man page as well. Brian will add a raiden_debug section to the man page
-- To view, visit https://review.coreboot.org/c/flashrom/+/43527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2da26469120c5304bc129b5578fcb7ca805fc1d1 Gerrit-Change-Number: 43527 Gerrit-PatchSet: 5 Gerrit-Owner: Mary Ruthven <mruthven@chromium.org> Gerrit-Reviewer: Brian Nemec <bnemec@chromium.org> Gerrit-Reviewer: Brian Nemec <bnemec@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Andrey Pronin <apronin@chromium.org> Gerrit-CC: Vadim Bendebury <vbendeb@chromium.org> Gerrit-Comment-Date: Tue, 21 Jul 2020 00:31:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org> Comment-In-Reply-To: Andrey Pronin <apronin@chromium.org> Gerrit-MessageType: comment