View Change
1 comment:
File flashrom.c:
Patch Set #5, Line 1379: }
I'm a bit confused here. Do we allow such layouts at all? Will […]
I could think of a future use that might be useful if/once fmap support is implemented: if you use a layout that reflects fmap stuff will overlap because subsections...
This would prevent such use case.
What should be done is to make sure that the include args regions don't overlap.
To view, visit change 23021. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 5
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nicola Corna <nicola@corna.info>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 08 Jan 2018 21:25:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No