Attention is currently required from: Edward O'Callaghan.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 8:
why though?
Meson looks up if the file xyz.c exists when calling file("xyz.c"). Furthermore it keeps track of the directory of the file. This is handy when using multiple directories.
Is there a need of mention it in the commit msg? Meson has this function and you should use it to keep thinks easy.
To view, visit change 64384. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I346b5468b4203f1521ec73a90f93ff3b13ebf43c
Gerrit-Change-Number: 64384
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Mon, 23 May 2022 16:34:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment