Attention is currently required from: Anastasia Klimchuk, Hsuan-ting Chen.

1 comment:

Commit Message:
- Patch Set #2, Line 9:
```
It's not valid to separately check the major and minor versions. The
proper minor check would be something like:

  if (fmap->ver_major == FMAP_VER_MAJOR &&
      fmap->ver_minor > FMAP_VER_MINOR)
```
  Brian, thank you so much for lots of details and links, this is really cool!
  👍
  However, I found one gem in cbfstool code , which is a comment for the `is_valid_fmap` function,
  /* Make a best-effort assessment if the given fmap is real */
  If you could add this comment to the functions, that would be it! Thank you!
  Done. Thanks for looking!

To view, visit change 79060. To unsubscribe, or for help writing mail filters, visit settings.