Attention is currently required from: Aarya, Nikolai Artemiev, Sergii Dmytruk.
3 comments:
File cli_output.c:
Patch Set #4, Line 119: 16 * FLASHROM_PROGRESS_NR
For 100% it will be 13 chars which I rounded to 16. `\b \b` is: […]
Oh this is a backspace that is not deleting characters! Sorry I got so confused.
I made an attempt to introduce the flag. It is a bit sad that I added a global state, but it seems this is how cli_output currently works :\
To test , running the same commands as is in your commit message will backspace and print on the top. But when I added -VVV , I got lots of messages in between progress indicator %, so I could see in debugger that new line is printed instead of backspace.
(the terminal explodes when you give -VVV to dummy, it prints every byte)
File flashrom.c:
/* const size_t flash_size = flashctx->chip->total_size * 1024; */
/* const size_t page_size = flashctx->chip->page_size; */
Sure.
Done
Patch Set #5, Line 1958: init_progress(flashctx, FLASHROM_PROGRESS_READ, flash_size); // WTF?
I think it was before addressing progress reporting on SPI reads, so adding this line caused progres […]
Okay I removed the comment.
To view, visit change 84102. To unsubscribe, or for help writing mail filters, visit settings.