Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, David Hendricks.
View Change
1 comment:
Patchset:
Patch Set #2:
My point is: do whatever you can to identify chips programmatically, rather than relying on people and their "first choice", unless you plan to provoke massive bricking.
I agree completely. However, there are certainly cases where there is no harm in selecting the first chip of multiple, and where having the user disassemble the device to determine the correct chip simply isn't feasible. If the consensus is that this option isn't a good fit for upstream, then I'll just keep it in my fork
To view, visit change 85160. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0427b1ef80e4eca16623f0fc9119d79f7dd62551
Gerrit-Change-Number: 85160
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anton Samsonov <avscomputing@gmail.com>
Gerrit-CC: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Anton Samsonov <avscomputing@gmail.com>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Mon, 16 Dec 2024 17:56:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anton Samsonov <avscomputing@gmail.com>
Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>