Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Sergii Dmytruk.

View Change

3 comments:

• File flashchips.c:

  • Patch Set #18, Line 6711: FEATURE_WRSR_EXT

    The datasheet suggests this won't work, AFAICT, and I guess this path […]

    At least according to datasheet rev 2.1 the WRSR (01h) command can write both registers together, I don't remember whether I tested it though.

  • Patch Set #18, Line 6872: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP,

    Spurious change?

    Done

• File spi25_statusreg.c:

  • Patch Set #17, Line 109:

    if (spi_read_register(flash, STATUS1, &sr1))
    				return 1;
    

    Would it make sense to print an error here?

    Done

To view, visit change 58570. To unsubscribe, or for help writing mail filters, visit settings.