Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
View Change
1 comment:
File programmer.c:
Patch Set #3, Line 100: if (data)
While this is consistent with the other patches already merged so maybe worth doing as a cleanup pat […]
Just to clarify some ambiguity in my writing here. The manual cases of `data` getting set in the drivers, which this branch is effectively working around, just be collapsed instead of the intermediate workaround here.
To view, visit change 54169. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I95bc92f6c54c5bcdac1c522ca87054aaffed0f40
Gerrit-Change-Number: 54169
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Fri, 21 May 2021 00:59:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment