Patch Set 1:

Patch Set 1: -Code-Review

This should be fixed in the parent change, CB:39965

How do I do that ?
I tried to squash / amend but I have not convinced Gerrit

Gerrit might be getting confused due to the Change-Id. Gerrit uses the Change-Id in the commit message to track the relationship between patches and assign them numbers. When you squash you need to remove the Change-Ids of patches you are squashing from whatever the resulting commit message is.

So in this case when you squash this patch into the the previous one in the chain (CB:39965) you need to remove "Change-Id: If70834715a51dea4111ba56e85df0680ed25c7a4" from the resulting commit message.

View Change

To view, visit change 39966. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If70834715a51dea4111ba56e85df0680ed25c7a4
Gerrit-Change-Number: 39966
Gerrit-PatchSet: 1
Gerrit-Owner: Martijn Berger
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks@gmail.com>
Gerrit-Comment-Date: Wed, 01 Apr 2020 00:37:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment