Attention is currently required from: Nikolai Artemiev.

Patch set 3:Code-Review +2

View Change

1 comment:

• File include/flash.h:

  • Patch Set #1, Line 159: #define UNERASED_VALUE(flash)

    It's a useful counterpart to `ERASED_VALUE()` and it might be helpful for erase optimization code et […]

    The thoughts I had: we have ERASED_VALUE which is one value (for a given chip), but technically unerased value is any other value which is not ERASED_VALUE. Like for a real chip, there could be any data written. There is no such operation as "unerase chip".
    For unit tests, yes it makes sense to create a mock "unerased chip memory" with just one and the same "unerased value".

    If everyone else agrees, I am fine to have the macro here.

To view, visit change 69130. To unsubscribe, or for help writing mail filters, visit settings.