Attention is currently required from: Angel Pons, Nikolai Artemiev, Sergii Dmytruk.

Patch set 22:Code-Review +1

View Change

3 comments:

• File flash.h:

  • Patch Set #22, Line 145: #define FEATURE_RDSR2 (1 << 21)

    Isn't this implied by the above and function pointers that make use of it?
    If it is redundant, it only creates more things to check for in the code.

  • Patch Set #22, Line 147:

    Only one empty line please.

• File flashchips.c:

  • Patch Set #18, Line 6711: FEATURE_WRSR_EXT

    At least according to datasheet rev 2. […]

    Interesting, looks like the datasheet is inconsistent. It first states:

     "CS# must be driven high after the eighth of the data Byte has been
      latched in. If not, the Write Status Register (WRSR) command is not
      executed."

    Later it says one could write SR1 and SR2 with 01h...

    I'd prefer to have it tested. And a comment about the datasheet oddity
    would be nice.

To view, visit change 58570. To unsubscribe, or for help writing mail filters, visit settings.