Attention is currently required from: Sergii Dmytruk.
View Change
2 comments:
Commit Message:
Patch Set #1, Line 7: writeprotect
Done
Git log takes care about the actual files touched. The prefix, as it was
introduced in coreboot and later here in flashrom, should just provide a
topic. So that people can filter patches / emails quickly. There is no
need to make it a file name.
File writeprotect.c:
Patch Set #1, Line 159: new
Done
I don't quite follow, how can it be expected? Should the flash chip
predict what we want it to be?
To view, visit change 66754. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I81d2d3fc0a103ee00ced78838d77fe33a9d3056a
Gerrit-Change-Number: 66754
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Fri, 07 Oct 2022 12:17:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-MessageType: comment