Review comments fixed, expect for the code copied from dediprog: I will wait for the authors feedback on the relicensing to GPL v2+.
16 comments:
Patch Set #8, Line 967: NI845X_LIBS += -L'${PROGRAMFILES(x86)}\National Instruments\NI-845x\MS Visual C'
Please try the following: […]
Done
it seems you dropped this from the digilent_spi description
Done
*
*/
#include <ctype.h>
Please remove this paragraph.
Done
Patch Set #8, Line 20: #include <string.h>
remove, please. Makefile already takes care of that.
Done
No CamelCase please, same for all other new identifiers.
Done
Patch Set #8, Line 43: static char error_string_buffer[1024];
This is not supposed to be global, as you added it as an […]
Done
Patch Set #8, Line 50: kNi845x33Volts,
obviously
Done
no space after asterisk
Done
should be `static const`
Done
Patch Set #8, Line 117: ial_as_numbe
should be `const char`
Done
no space after asterisk
Done
Why is it called `handle`? isn't it rather `resource_value`?
Done
Patch Set #8, Line 136: alformed reso
should use the `serial` function parameter instead
Done
Patch Set #8, Line 160: if (tmp) {
else (if != 0)?
Done
You can use `sizeof()` instead, as we know it's a char array.
Done
Patch Set #8, Line 169: * @brief ni845x_spi_open_resource
This whole block is very confusing. I don't see bigger problems, […]
Done
To view, visit change 25683. To unsubscribe, or for help writing mail filters, visit settings.