This is obsolete. We changed the spi_read_chunked() implementation
long ago, because nobody knew any SPI flash that would have a page-
size limitation for reads. So far nobody complained.

Nice to see, though, that my patches get around :)

Thanks for the review Nico, do you mind pointing me to the commit you are referring to so I can get my head around reconciling the differences between the two trees.

We have a feature flag for chips called UNBOUND_READ that builds on top of this, are you suggesting that is completely obsolete and not needed for each chip definition now?

Just for thoroughness, what was roughly mentioned on IRC:

• Support was added upstream with 731316a9 (Enable continuous SPI reads)
• A flag doesn't seem to be needed, all SPI flashes should support it.

And my personal opinion on the `ignore_error()` feature downstream:

• Doesn't seem useful: why tell flashrom to do something that can't be done in the first place?
• spi_read_unbound(), downstream, looks broken: if the `chunksize` doesn't align with a protected region, it would fake data outside of that region.

View Change

To view, visit change 34584. To unsubscribe, or for help writing mail filters, visit settings.