This is obsolete. We changed the spi_read_chunked() implementation
long ago, because nobody knew any SPI flash that would have a page-
size limitation for reads. So far nobody complained.

Nice to see, though, that my patches get around :)

Thanks for the review Nico, do you mind pointing me to the commit you are referring to so I can get my head around reconciling the differences between the two trees.

We have a feature flag for chips called UNBOUND_READ that builds on top of this, are you suggesting that is completely obsolete and not needed for each chip definition now?

Just for thoroughness, what was roughly mentioned on IRC:

And my personal opinion on the `ignore_error()` feature downstream:

View Change

To view, visit change 34584. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I804545aeb1b827ffdd41b21024fd618475e8263a
Gerrit-Change-Number: 34584
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 03 Aug 2019 14:58:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment