Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
Makefile: Turn x86-arch comments into `if`

Actually check what the comments suggest. Supposed to fix non-x86 on
NetBSD and OpenBSD.

Change-Id: I440919c12e54ca4371e21bc8d1b5ab64692fb4b8
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/52486
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M Makefile
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index be6e551..4d68cdb 100644
--- a/Makefile
+++ b/Makefile
@@ -1186,12 +1186,14 @@
PROGRAMMER_OBJS += physmap.o hwaccess.o

ifeq ($(TARGET_OS), NetBSD)
-# For (i386|x86_64)_iopl(2).
+ifeq ($(ARCH), x86)
PCILIBS += -l$(shell uname -p)
+endif
else
ifeq ($(TARGET_OS), OpenBSD)
-# For (i386|amd64)_iopl(2).
+ifeq ($(ARCH), x86)
PCILIBS += -l$(shell uname -m)
+endif
else
ifeq ($(TARGET_OS), Darwin)
# DirectHW framework can be found in the DirectHW library.

To view, visit change 52486. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I440919c12e54ca4371e21bc8d1b5ab64692fb4b8
Gerrit-Change-Number: 52486
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged