Patch Set 1:

Sorry, I really don't want any quarrel. But if we add 15 lines
to dedup 5, I have to ask, what does this fix? Somebody put much
care into this table in the past. And now we want to destroy that
just for the sake of doing something?

I don't see why this would be an improvement. If the short forms are not obvious, maybe print their meaning as done with PREW?

 (P = PROBE, R = READ, E = ERASE, W = WRITE, - = N/A)

Patch set 1:Code-Review -1

View Change

1 comment:

To view, visit change 37407. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie0a0b45c6466d14447aca443c2697e2048c6ef14
Gerrit-Change-Number: 37407
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 25 Mar 2020 12:09:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment