Attention is currently required from: Richard Hughes, Daniel Campello, Angel Pons, Anastasia Klimchuk, Patrick Rudolph.

View Change

3 comments:

• File include/libflashrom.h:

  • Patch Set #17, Line 85: struct flashrom_update_progress *progress_state

    I am a little confused on intended life-times here and why we have two copies of progress_state? We […]

    X: I guess just document this signature better so it is clear why the passed copy is used and not the one in flashctx if there is a reason?

  • Patch Set #17, Line 97: update

    `s/update/set||init/` the func name made me dizzy.

• File libflashrom.c:

  • Patch Set #17, Line 84: flashctx->progress_callback(flashctx, flashctx->progress_state);

    Y: Because in theory this could become `flashctx->progress_callback(flashctx);` given the above in X.

To view, visit change 49643. To unsubscribe, or for help writing mail filters, visit settings.