View Change
1 comment:
File meson.build:
Patch Set #3, Line 280: need_raw_access = true
> this change makes meson to behave the same as the Makefile. […]
You are right! I did not notice that the Makefile does not request libpci. I was following the gentoo ebuild dependency when I looked at rayer_spi: https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-apps/flashrom/flashrom-1.2-r3.ebuild#n84
Is the ebuild wrong regarding the libpci dependency? If so, I could add back the need_raw_access=true line for config_rayer_spi on a follow up CL.
To view, visit change 51577. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id3fa4ec7a735b81e989ba9fe2b53b18d0956627a
Gerrit-Change-Number: 51577
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Mario Limonciello <superm1@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Richard Hughes <hughsient@gmail.com>
Gerrit-Reviewer: Richard Hughes <richard@hughsie.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 29 Mar 2021 20:52:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Daniel Campello <campello@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment