Attention is currently required from: Michał Żygowski, Angel Pons.
View Change
2 comments:
File ich_descriptors.c:
Patch Set #3, Line 946: } else if (upper->MDTBA == 0x00) {
As suggested in 55577 we may also reuse guess_ifd_2_chipset from coreboot's ifdtool
It seems much more invasive, do you want to do it? Anything to do here?
Patch Set #3, Line 965: firmware
Certainly not. […]
Done
To view, visit change 55647. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I587ad1abe390843d4a9e74431b6fc4b63f8ba512
Gerrit-Change-Number: 55647
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sat, 19 Jun 2021 11:58:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski@3mdeb.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment