Attention is currently required from: Riku Viitanen.

3 comments:

Patchset:
- Patch Set #2:
  Riku, thank you for your patch! I have two small comments.
File serprog.c:
- Patch Set #2, Line 827: cs = extract_programmer_param_str(cfg, "cs");
  Since you are adding new programmer param, you need to update manpage as well.
  Specifically, manpage is generated from the file `doc/classic_cli_manpage.rst`, look for the section called `serprog programmer` and you can add a paragraph about `cs` param.
  May be useful to mention where it is supported (from your code, there are error paths, seems like it's not supported everywhere).
  Thank you!
- Patch Set #2, Line 833:
```
msg_perr("Error: Invalid chip select requested! "
				         "Only 0-255 are valid.\n");
```
  Not critical comment, but: this can be one line (and same for another error message before).
  Our guidelines for line length are here: https://www.flashrom.org/dev_guide/development_guide.html#coding-style

To view, visit change 80498. To unsubscribe, or for help writing mail filters, visit settings.