I'm not sure if this could be split up a bit.

Patch set 7:Code-Review +1

View Change

5 comments:

• File writeprotect.h:

  • Patch Set #7, Line 44: wp_wpce775x

    Do we have this programmer upstream?

• File writeprotect.c:

  • Patch Set #7, Line 873: uint8_t mx25l_read_config_register(const struct flashctx *flash);//XXX

    Hmm?

  • Patch Set #7, Line 1132: //case ATMEL_AT25SF128A:

    Hm?

  • Patch Set #7, Line 1473: /* FIXME: this is NOT endian-free copy. */

    How about providing a union instead of a struct? Here's an example: https://github.com/coreboot/coreboot/blob/dc0c08100124278efc9ed91952378b01905c45b6/src/northbridge/intel/sandybridge/raminit_common.h#L46

  • Patch Set #7, Line 2236:

    //case SPANSION_ID:
    	//	switch (flash->chip->model_id) {
    	//	case SPANSION_S25FS128S_L:
    	//	case SPANSION_S25FS128S_S: {
    	//		*wp = &s25fs128s_wp;
    	//		(*wp)->descrs = s25fs128s_ranges;
    	//		*num_entries = ARRAY_SIZE(s25fs128s_ranges);
    	//		break;
    	//	}
    	//	case SPANSION_S25FL256S_UL:
    	//	case SPANSION_S25FL256S_US: {
    	//		*wp = &s25fl256s_wp;
    	//		(*wp)->descrs = s25fl256s_ranges;
    	//		*num_entries = ARRAY_SIZE(s25fl256s_ranges);
    	//		break;
    	//	}
    	//	default:
    	//		msg_cerr("%s():%d Spansion flash chip mismatch (0x%04x)"
    	//			", aborting\n", __func__, __LINE__,
    	//			flash->chip->model_id);
    	//		return -1;
    	//	}
    	//	break;
    

    Um?

To view, visit change 40325. To unsubscribe, or for help writing mail filters, visit settings.