Attention is currently required from: Nico Huber, Edward O'Callaghan, Daniel Campello, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
View Change
1 comment:
Patchset:
Patch Set #2:
> - Backwards-compatible with flashrom syntax prior to CB:23021 […]
Yeah, I remember that was a concern. Does anybody remember exactly why? IIRC it was considered complicated, yet non-positional files have been supported and standard in Unix commands since before most of us were born so I have a hard time understanding that argument.
Using non-positional files as illustrated in https://flashrom.org/Per_region_file_arguments#Use_cases enables us to treat chip-sized files and region-sized files with the same, intuitive syntax without added mode flags or inconsistent use of -i/-r/-w/-v as in other proposals.
To view, visit change 30979. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idfba11ec9991aac423b07f68f7dc45e7bebbb06b
Gerrit-Change-Number: 30979
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Carl-Daniel Hailfinger <hailfinger@gmail.com>
Gerrit-Reviewer: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: Stefan T <stefan.tauner@gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Daniel Campello <campello@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Tue, 11 May 2021 17:08:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com>
Comment-In-Reply-To: Daniel Campello <campello@chromium.org>
Gerrit-MessageType: comment