Attention is currently required from: Nico Huber, Anastasia Klimchuk.

Patch set 1:Code-Review +2

View Change

3 comments:

• File usbblaster_spi.c:

  • Patch Set #1, Line 55: struct ftdi_context ftdic;

    Having a struct with only one member looks odd, but it makes sense for consistency with other programmers.

    (No action needed)

  • Patch Set #1, Line 165:

    static int usbblaster_shutdown(void *data)
    {
    	free(data);
    	return 0;
    }
    

    Seems fine to me. […]

    Makes sense. This patch changes programmer context storage from a global variable to dynamically-allocated memory, and one needs to free() this memory to avoid memory leaks. Adding a shutdown function to do this is a very reasonable thing to do.

  • Patch Set #1, Line 185: struct ftdi_context ftdic;

    We could allocate `usbblaster_data` early and use `usbblaster_data->ftdic` instead of having a second local variable. Can be done in a separate patch.

To view, visit change 54044. To unsubscribe, or for help writing mail filters, visit settings.