Attention is currently required from: Nico Huber, Edward O'Callaghan, Nikolai Artemiev, Sergii Dmytruk.

View Change

1 comment:

• File writeprotect.c:

  • Patch Set #22, Line 122: INVALID_REG

    I've changed it to (INVALID_REG + 1), perhaps STATUS1 would be better though. […]

    IMO it is a bit confusing when loop starts with "invalid" value. And even when it's "invalid" + 1 , it takes time to understand why this is fine. I would vote for STATUS1, then it reads naturally like "start with 1 and loop until max value".

To view, visit change 58479. To unsubscribe, or for help writing mail filters, visit settings.