Patch Set 2:

Patch Set 2:

Patch Set 1:

Patch Set 1:

(out of topic)
Do you know why flashrom v1.2-19-g0eee5bb will take longer time than flashrom v0.9.7-r1711,
and it displays so many and many of "Error: SCIP never cleared!" ?

Please see https://pastebin.com/ZHF9vAj3

Thank you

Does commit 15f539c8c97 relate at all? Not sure what commit g0eee5bb refers to.

sorry, it is the latest version.
./flashrom -v
flashrom v1.2-19-gfe6b98b on Linux 5.4.0-4-amd64 (x86_64)
flashrom is free software, get the source code at https://flashrom.org

( commit fe6b98b91ccf )

here we go (Thx to Angel Pons):
flashrom$ git bisect good
92d6a861ce0e4727c911fd8d6aeba312b805f765 is the first bad commit
commit 92d6a861ce0e4727c911fd8d6aeba312b805f765
Author: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Date: Fri Oct 25 00:33:37 2013 +0000

    Refactor Intel Chipset Enables

- Combine enable_flash_ich_4e() and enable_flash_ich_dc() to
enable_flash_ich_fwh().
- Remove unjustified (chipset) name parameters from various
enable_flash_ich* functions.
- Make Poulsbo and Tunnel Creek use generic enables by refining existing
functions to work with them, including everything in ichspi.c.
- Refactor enable_flash_ich_fwh_decode() to be called unconditionally for
all chipsets.
- Add support for Intel Atom Centerton (S12x0).
- Recombine ICH2/3/4/5 to CHIPSET_ICH2345 because we treat them equally
anyway.
- Move spibar handling out of ich_init_spi() into enable_flash_ich_spi()
- Various small cleanups.

Corresponding to flashrom svn r1761.

Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
 chipset_enable.c | 412 ++++++++++++++++++++++++++-----------------------------
ichspi.c | 61 ++------
programmer.h | 12 +-
3 files changed, 214 insertions(+), 271 deletions(-)

https://paste.flashrom.org/view.php?id=3283
https://paste.flashrom.org/view.php?id=3282

View Change

To view, visit change 39896. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7dd26665a0133175949c11717837e9de68a1bf71
Gerrit-Change-Number: 39896
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 28 Mar 2020 17:26:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment