Attention is currently required from: Aarya, Vincent Fazio.

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    Anastasia,

    Here are the changes to removing verification 2 and 3 as discussed. Thank you so much for your help in reviewing and discussing these changes. Testing information is posted below, with timing improvements obtained from comparing this data to the `New Erase Path` group from patchset 1's testing summary.

    ```
    Testing summary:

    Verifications:

    	Inside erase block
     	 1. check_erased_range in erasure_layout.c lines 341-345
    	  2. check_erased_range in erasure_layout.c lines 353-359
    	  
    	After erasing
    	  3. verify_range in erasure_layout.c lines 388-394
    	  4. verify block in flashrom.c lines 2329-2348 (only when writing)

    New Erase Path Sans Verification 2 and 3:

    	1. Erase entire chip
    	
    	    Erase chip contents: 85.622
    	    Write to chip: 0.080 (artifact from timing capture location)
    	    Total execution time: 86.269

    	    Timing improvements: 
    	   	    - 40% faster to erase the chip contents due to the removal of verification 2
    	   	    - 57% faster overall from the removal of 2 and 3

    	2. Program flash starting with empty contents
    	
    	    Read previous contents: 57.133
    	    Erase relevant parts: 0 (already empty)
    	    Write time: 25.201
    	    Verify contents: 58.840
    	    Total execution time: 142.349

    		Timing improvements:
    			- 29% faster overall from the removal of verification 3

    
    	3. Program different contents

    	    Read previous contents: 57.128
    	    Erase relevant parts: 21.019
    	    Write time: 10.322
    	    Verify contents: 58.824
    	    Total execution time: 148.380
    	    
    	    Timing improvements:
    	    	- 18% faster to erase relevant contents from removing verification 2
    	    	- 29% faster overall from the removal of 2 and 3
    ```

To view, visit change 79354. To unsubscribe, or for help writing mail filters, visit settings.