Attention is currently required from: Nico Huber, Edward O'Callaghan, Evan Benn.
Patch set 4:Code-Review +1
2 comments:
Patchset:
Part of me wants to split this patch into smaller ones. But I am interested what other people are thinking.
Smaller ones in my mind
1) Use macros for printing format everywhere
2) Delete chipoff and replace it with chipsize
3) Replace size_t with chipsize_t
4) replace unsigned int with chipsize_t
In any case, even if everyone agrees on splitting: probably better do it later when code is mostly reviewed and any other comments resolved.
File cli_classic.c:
Patch Set #4, Line 146: *start != tmp
What is this condition checking? I am confused because the previous line made the assignment and this condition seems to check whether the assignment works?
I am guessing this has something to do with changing types? (since it wasn't in the code before)
To view, visit change 67004. To unsubscribe, or for help writing mail filters, visit settings.