Attention is currently required from: Angel Pons, Nikolai Artemiev, Sergii Dmytruk.
3 comments:
File flash.h:
Patch Set #22, Line 201: Complete
`Complete` seems a bit exaggerated. Given the many different
implementations, I'm not sure if we can ever have that. Actually,
I'm missing one thing already, `WPS`.
Please add comments what all these acronyms mean.
File flash.h:
/* Complete description of a chip's write protection configuration */
struct flashrom_wp_chip_config {
size_t srp_bit_count;
uint8_t srp[MAX_SRP_BITS];
bool cmp_bit_present;
uint8_t cmp;
bool sec_bit_present;
uint8_t sec;
bool tb_bit_present;
uint8_t tb;
size_t bp_bit_count;
uint8_t bp[MAX_BP_BITS];
};
This is specific to SPI flash chips.
Well, not by nature, probably by coincidence. I don't see why one couldn't
make a flash chip with such registers but without SPI interface.
However, I also see that it doesn't seem to belong here. As the commit
message suggests, this is the representation used by the writeprotect
code (not the API?), it should be private to chip drivers and
`writeprotect*.c` I guess.
To view, visit change 58478. To unsubscribe, or for help writing mail filters, visit settings.