1 comment:
Patch Set #5, Line 164: if (chip->hwversion == hwversion && chip->ediid == ediid) {
After a closer look, it looks like this is not consistent with the way it's done for spi25 chips. […]
Originally it was msg_cdbg but I changed it to msg_cdbg2 after Nico's request. Do you think its a good idea to change it back to msg_cdbg ? Also, right now if hwversion and/or ediid do not match these values , the exit code is 0 - while, if they match, the exit code is 1. If we replace it with a single msg line, what exit code should it be? "return 1" for both cases?
To view, visit change 23261. To unsubscribe, or for help writing mail filters, visit settings.