Felix Singer submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
flashchips: Fix N25Q512 bulk erase

The N25Q is a stacked device, so it requires 0xC4 to perform a die
erase.

Signed-off-by: Jacob Creedon <jcreedon@google.com>
Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84
Reviewed-on: https://review.coreboot.org/c/flashrom/+/34489
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67847
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M flashchips.c
1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/flashchips.c b/flashchips.c
index d85ea74..4dc50f7 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -10555,8 +10555,8 @@
.eraseblocks = { {64 * 1024, 1024} },
.block_erase = spi_block_erase_d8,
}, {
- .eraseblocks = { {65536 * 1024, 1} },
- .block_erase = spi_block_erase_c7,
+ .eraseblocks = { {32768 * 1024, 2} },
+ .block_erase = spi_block_erase_c4,
}
},
.printlock = spi_prettyprint_status_register_n25q, /* TODO: config, lock, flag regs */

To view, visit change 67847. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84
Gerrit-Change-Number: 67847
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Jacob Creedon <jcreedon@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged