Attention is currently required from: Simon Buhrow, Nico Huber, Aarya, Anastasia Klimchuk.
View Change
1 comment:
File flashrom.c:
Patch Set #72, Line 1349: static int erase_by_layout
what you want to do is have both paths parallel to one another and atomically switch over to the nex […]
A path to do this could be;
- factor out the erase logic into its own C file from flashrom.c
- put your implementation into another C file,
- finally have the functions in flashrom.c be the entry-point to switch between those two?
The benefits here would be, easy A/B testing, less disruptive, better long term vision on flashrom.c kitchsink syndrome, more modularity for the erasure path.
To view, visit change 66104. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 73
Gerrit-Owner: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Sat, 10 Dec 2022 23:44:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment