Edward O'Callaghan has uploaded this change for review.

View Change

programmer.h,chipset_enable.c: Make penable cb more descript

The enable_flash callback function pointer embedded within
the penable struct is used by the chipset_enable entry-point
to dispatch to the correct concrete implementation. The handles
have the canonical form `flash_enable_<chipset-name>()` and
therefore `doit()` is hard to comprehend while groking code
and seeing to what it refers to. It is also a little more
confusing as there use to be another doit() in flashrom
once upon a time.

BUG=none
TEST=builds

Change-Id: I8b3a4ec51ea488c40c20ccafea883f8dea93577d
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
---
M chipset_enable.c
M programmer.h
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/52364/1
diff --git a/chipset_enable.c b/chipset_enable.c
index d5c10c4..fd8bec2 100644
--- a/chipset_enable.c
+++ b/chipset_enable.c
@@ -2138,7 +2138,7 @@
continue;
}
msg_pinfo("Enabling flash write... ");
- ret = chipset_enables[i].doit(dev, chipset_enables[i].device_name);
+ ret = chipset_enables[i].enable_flash_xxx(dev, chipset_enables[i].device_name);
if (ret == NOT_DONE_YET) {
ret = -2;
msg_pinfo("OK - searching further chips.\n");
diff --git a/programmer.h b/programmer.h
index 29a100b..93540a6 100644
--- a/programmer.h
+++ b/programmer.h
@@ -225,7 +225,7 @@
const enum test_state status;
const char *vendor_name;
const char *device_name;
- int (*doit) (struct pci_dev *dev, const char *name);
+ int (*enable_flash_xxx) (struct pci_dev *dev, const char *name);
};

extern const struct penable chipset_enables[];

To view, visit change 52364. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8b3a4ec51ea488c40c20ccafea883f8dea93577d
Gerrit-Change-Number: 52364
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: newchange