Thanks for the great work on this series! I had planned on
submitting follow-up patches to this (I have not given up) so as
Nico mentioned, it would be nice that I am still listed as author
and have a signed-off-by line in the commits that get landed. I
would be more than happy to add your signed-off line as well to
show that you were also involved with this effort!

I think the easiest way to do things would be that I submit my
rebased commit with your signed-off-by line so we can have the
right author.

Just to rebase your commits - will not work because flashrom source code has been significantly changed (most importantly "Kill doit()") - thats why the additional modifications (included to my commits above) are required to make them work. So I am going to try to follow Nico Huber instruction to change the author to your name

View Change

To view, visit change 23258. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b0de8568e31f9bf263ba0ad6b051e837477b6b
Gerrit-Change-Number: 23258
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Kocialkowski <contact@paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 03 Feb 2018 12:53:29 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No